Cordy/Cairn
2
1
Fork 0
Code Issues 20 Pull requests Projects Releases Packages Wiki Activity Actions

ocm: probe folder-ness at accept, the wire resourceType lies for Nextcloud (#464) #471

Merged
Cordy merged 3 commits from fix-464d into main 2026-09-10 01:37:01 +00:00
Conversation 0 Commits 3 Files changed 5 +109
Cordy commented 2026-09-10 01:35:05 +00:00
Owner
Copy link

NC sends resourceType "file" for folder shares too, so inbound folders landed as files (Download, no Browse — the Summer Slam dogfood finding). New Client.IsRemoteDir (depth-0 PROPFIND, collection = trailing-slash href; TDD red witnessed), Store.SetShareInFolder, and a best-effort probe in the accept path that corrects the flag. Already-accepted shares keep their stored flag — end + re-accept once to heal.

NC sends resourceType "file" for folder shares too, so inbound folders landed as files (Download, no Browse — the Summer Slam dogfood finding). New Client.IsRemoteDir (depth-0 PROPFIND, collection = trailing-slash href; TDD red witnessed), Store.SetShareInFolder, and a best-effort probe in the accept path that corrects the flag. Already-accepted shares keep their stored flag — end + re-accept once to heal.
ocm: probe folder-ness at accept, the wire resourceType lies for Nextcloud (#464)
All checks were successful
ci / test-and-build (pull_request) Successful in 47s
Details
dc0f70e321
Cordy merged commit 386b22a2bb into main 2026-09-10 01:37:01 +00:00
Cordy deleted branch fix-464d 2026-09-10 01:37:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#471
No description provided.
Delete branch "fix-464d"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?