Cordy/Cairn
2
1
Fork 0
Code Issues 20 Pull requests Projects Releases Packages Wiki Activity Actions

ocm: derive the legacy webdav endpoint from discovery, Basic auth with the secret (#474) #475

Merged
Cordy merged 3 commits from fix-474 into main 2026-09-10 10:31:33 +00:00
Conversation 0 Commits 3 Files changed 5 +190 -27
Cordy commented 2026-09-10 10:29:24 +00:00
Owner
Copy link

Root cause of "Summer Slam still shows as a file" — and of every remote read against Nextcloud: the legacy dialect carries no WebDAV URI, so all access paths targeted the NC server root, and the accept-time probe's error was silently swallowed.

  • remoteBase: explicit protocol.webdav.uri unchanged (Bearer); empty URI resolves the peer's cached Disco.WebdavRoot with live-discovery fallback (spec Share Access step 5).
  • authorize: Basic auth, shared secret as username + X-Requested-With for legacy targets; Bearer otherwise. Wired into IsRemoteDir, ListRemote, FetchRemote — existing stored rows heal without re-sharing.
  • IsRemoteDir recognises the resourcetype collection element (trailing-slash heuristic stays as fallback).
  • Accept path logs probe failures via slog.Warn("ocm folder probe failed", …).
  • TDD: red witnessed on runner (404 probe + collection case) before the implementation splices; full suite green.

Closes #474.

Root cause of "Summer Slam still shows as a file" — and of every remote read against Nextcloud: the legacy dialect carries no WebDAV URI, so all access paths targeted the NC server root, and the accept-time probe's error was silently swallowed. - `remoteBase`: explicit `protocol.webdav.uri` unchanged (Bearer); empty URI resolves the peer's cached `Disco.WebdavRoot` with live-discovery fallback (spec Share Access step 5). - `authorize`: Basic auth, shared secret as username + `X-Requested-With` for legacy targets; Bearer otherwise. Wired into `IsRemoteDir`, `ListRemote`, `FetchRemote` — existing stored rows heal without re-sharing. - `IsRemoteDir` recognises the `resourcetype` `collection` element (trailing-slash heuristic stays as fallback). - Accept path logs probe failures via `slog.Warn("ocm folder probe failed", …)`. - TDD: red witnessed on runner (404 probe + collection case) before the implementation splices; full suite green. Closes #474.
ocm: derive the legacy webdav endpoint from discovery, Basic auth with the secret (#474)
All checks were successful
ci / test-and-build (pull_request) Successful in 54s
Details
f1e8260660
Cordy merged commit d787e683ea into main 2026-09-10 10:31:33 +00:00
Cordy deleted branch fix-474 2026-09-10 10:31:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#475
No description provided.
Delete branch "fix-474"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?