Transfers: retention-window notice as an attached top band #519

Merged

Cordy merged 3 commits from fix-tfband into main

2026-09-13 17:33:48 +00:00

Cordy commented

2026-09-13 17:32:39 +00:00

Owner

Dogfood report: the "Showing the last 90 days." row above the Transfers list rendered with footer corner treatment and looked like a bottom row placed on top.

Root cause: openTransfersView (#404) borrowed #listfoot — the file table's footer element — for the notice, so it carried footer styling wherever it appeared. Fix: the notice is now its own #tfwindow band in the ghead idiom — sunk background, top corners only, flush with the history card, with border and radius read from #listpane's own base rule at splice time (extracted 10px / 1px solid var(--lichen)) so the two surfaces match exactly. Shown per-view via body[data-fbview="transfers"] CSS, hidden in admin mode; the table footer goes back to being the table footer. Reuses the existing transfersWindow i18n key — no new strings. CHANGELOG v0.6.179.

Dogfood report: the "Showing the last 90 days." row above the Transfers list rendered with footer corner treatment and looked like a bottom row placed on top. Root cause: `openTransfersView` (#404) borrowed `#listfoot` — the file table's footer element — for the notice, so it carried footer styling wherever it appeared. Fix: the notice is now its own `#tfwindow` band in the ghead idiom — sunk background, top corners only, flush with the history card, with border and radius **read from `#listpane`'s own base rule at splice time** (extracted `10px` / `1px solid var(--lichen)`) so the two surfaces match exactly. Shown per-view via `body[data-fbview="transfers"]` CSS, hidden in admin mode; the table footer goes back to being the table footer. Reuses the existing `transfersWindow` i18n key — no new strings. CHANGELOG v0.6.179.

Cordy added 3 commits

2026-09-13 17:32:40 +00:00

one-shot: transfers 90-day notice becomes an attached top band (not the borrowed listfoot) e2bd20e523

one-shot: fix post-condition (element id is set in JS, not markup) 4929615f25

fix(transfers): retention-window notice as an attached top band

ci / test-and-build (pull_request) Successful in 54s

Details

31b92ec796

openTransfersView borrowed #listfoot (#404) for the 'Showing the last
{n} days' notice; the element carries footer styling, so above the
list it rendered with footer corners and looked upside-down. The
notice is now its own #tfwindow band in the ghead idiom - sunk
background, border and radius read from #listpane's own base rule so
the two surfaces match exactly, top corners only, flush with the
card - shown per-view via body[data-fbview] CSS (hidden in admin
mode). The table footer goes back to being the table footer.

Cordy scheduled this pull request to auto merge when all checks succeed

2026-09-13 17:32:48 +00:00