Cordy/Cairn
2
1
Fork 0
Code Issues 20 Pull requests Projects Releases Packages Wiki Activity Actions

feat(#529): share dialog stops suggesting federation; phone converted-preview fit #531

Merged
Cordy merged 4 commits from fix-389i into main 2026-09-14 00:34:21 +00:00
Conversation 0 Commits 4 Files changed 2 +17
Cordy commented 2026-09-14 00:33:16 +00:00
Owner
Copy link

Per the decision recorded on #529: minting a share link and addressing a user on another instance are different acts, so the "or send to a federated address" section leaves the share dialog — one global display:none on #sharedlg-fed, with the section's wiring, the OCM plumbing and the Federated view untouched, until the federated send gets its own designed flow (peering-style recipient picker; allow-list errors in the flow rather than as a permanent hint). This also removes the visibly cramped row from the phone dialog.

Also, at ≤480px, converted document previews (docx-preview pages) reflow to the screen width instead of clipping on the right: the page section drops its fixed inline width, heavy padding and shadow inside #pvbody.

Fence gate + node --check green; the share-dialog hide is deliberately global (all widths), as requested.

Per the decision recorded on #529: minting a share link and addressing a user on another instance are different acts, so the "or send to a federated address" section leaves the share dialog — one global `display:none` on `#sharedlg-fed`, with the section's wiring, the OCM plumbing and the Federated view untouched, until the federated send gets its own designed flow (peering-style recipient picker; allow-list errors in the flow rather than as a permanent hint). This also removes the visibly cramped row from the phone dialog. Also, at ≤480px, converted document previews (docx-preview pages) reflow to the screen width instead of clipping on the right: the page section drops its fixed inline width, heavy padding and shadow inside `#pvbody`. Fence gate + `node --check` green; the share-dialog hide is deliberately global (all widths), as requested.
feat(#529): share dialog stops suggesting federation; phone preview fit
All checks were successful
ci / test-and-build (pull_request) Successful in 52s
Details
713b42616c 
Minting a share link and addressing a user on another instance are
different acts, and mixing them made the dialog noisy and (at phone
width) visibly cramped - the recipient field, permission select and
send button fought over one row. Per the decision on #529 the
federated section leaves the share dialog: one global display:none
on #sharedlg-fed, with the wiring, the OCM plumbing and the
Federated view untouched, until the federated send gets its own
designed flow (peering-style recipient picker, allow-list errors in
the flow rather than as a permanent hint).

Also, at phone width, converted document previews (docx-preview
pages) reflow to the screen width instead of clipping on the right:
the page section drops its fixed width, heavy padding and shadow
inside the preview body.
Cordy scheduled this pull request to auto merge when all checks succeed 2026-09-14 00:33:26 +00:00
Cordy merged commit 0b2397b6ef into main 2026-09-14 00:34:21 +00:00
Cordy deleted branch fix-389i 2026-09-14 00:34:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#531
No description provided.
Delete branch "fix-389i"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?