Cordy/Cairn
2
1
Fork 0
Code Issues 20 Pull requests Projects Releases Packages Wiki Activity Actions

Share defaults actually take effect (#52 follow-up) #57

Merged
Cordy merged 1 commit from feat/share-defaults-wire into main 2026-07-29 05:21:27 +00:00
Conversation 0 Commits 1 Files changed 4 +13 -7
Cordy commented 2026-07-29 05:19:29 +00:00
Owner
Copy link

Completes the last wire from the settings panel: the share dialog now reads shareDefaultExpiry / shareAllowUploadDefault from the store instead of hardcoding 1 day / off.

  • openShareDialog pre-fills the expiry dropdown and upload checkbox from a serverSettings cache (fetched at page load, refreshed in-session from the PUT response when settings are saved).
  • Store defaults shareDefaultExpiry to "24h" for an unconfigured instance, so behavior is unchanged until an admin sets otherwise — and this disambiguates "unset" from an explicit "Never" (""), so an admin can now genuinely default shares to no-expiry if they want.

gofmt/vet/build/test + node --check green on the runner. Test updated for the new store default.

Completes the last wire from the settings panel: the share dialog now reads `shareDefaultExpiry` / `shareAllowUploadDefault` from the store instead of hardcoding 1 day / off. - `openShareDialog` pre-fills the expiry dropdown and upload checkbox from a `serverSettings` cache (fetched at page load, refreshed in-session from the PUT response when settings are saved). - Store defaults `shareDefaultExpiry` to `"24h"` for an unconfigured instance, so behavior is unchanged until an admin sets otherwise — and this disambiguates "unset" from an explicit "Never" (`""`), so an admin can now genuinely default shares to no-expiry if they want. gofmt/vet/build/test + `node --check` green on the runner. Test updated for the new store default.
fix(ui): share dialog reads org share defaults from settings store (#52 follow-up)
All checks were successful
ci / test-and-build (pull_request) Successful in 22s
Details
839c35c087
Cordy merged commit 55b30e183c into main 2026-07-29 05:21:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#57
No description provided.
Delete branch "feat/share-defaults-wire"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?