fix(#590): the My-shares heading is the basename the pure fn already carried #592

Merged

Cordy merged 1 commit from fix-590 into main

2026-09-18 01:30:56 +00:00

Cordy commented

2026-09-18 01:25:25 +00:00

Owner

One field. groupShares() returns both path and name — and its test for "each group carries the basename for its heading" was green the whole time — but sharesRenderMine() put g.path in the heading. The fix renders g.name and keeps the full path as the heading's title, so two files with one basename in different folders stay distinguishable on hover.

New: web/test/shares-view.test.js — the glue, not the mapping: lifts sharesRenderMine (plus the pure block and shareRoleBadge) and renders it against a fake DOM. Three claims: heading is the basename; full path survives as title; same basename in two folders yields two groups with distinct titles. This is the fourth instance of pure-block-right-wiring-wrong in the #571 slice, and the same lift-the-glue pattern as settings-load.test.js.

Red witnessed: heading rendered /home/nikola-test/moverini; workflow aborts if the test passes pre-fix. Green: all three, plus the full web suite and the #389 extract gate.

One field. `groupShares()` returns both `path` and `name` — and its test for "each group carries the basename for its heading" was green the whole time — but `sharesRenderMine()` put `g.path` in the heading. The fix renders `g.name` and keeps the full path as the heading's `title`, so two files with one basename in different folders stay distinguishable on hover. **New: `web/test/shares-view.test.js`** — the glue, not the mapping: lifts `sharesRenderMine` (plus the pure block and `shareRoleBadge`) and renders it against a fake DOM. Three claims: heading is the basename; full path survives as `title`; same basename in two folders yields two groups with distinct titles. This is the fourth instance of pure-block-right-wiring-wrong in the #571 slice, and the same lift-the-glue pattern as `settings-load.test.js`. **Red witnessed:** heading rendered `/home/nikola-test/moverini`; workflow aborts if the test passes pre-fix. **Green:** all three, plus the full web suite and the #389 extract gate.

Cordy added 1 commit

2026-09-18 01:25:26 +00:00