fix(#579): the sweep-off warning is slotted, toggled, and its dead twin removed #599

Merged

Cordy merged 1 commit from fix-579 into main

2026-09-18 02:58:17 +00:00

Cordy commented

2026-09-18 02:50:05 +00:00

Owner

Recon turned #579's either/or into a sharper finding: set-f-trashwarn is not a setting but the "deleted files accumulate without limit" notice, and it was doubly orphaned — never in SET_SLOTS (so it rendered on no page) and never toggled by syncTrashAuto (so even slotted it would never have appeared). A second orphan rode along: sdTrashWarn, a ×4-translated description for a "warn people in the file browser" feature that was never built and is referenced nowhere.

Per the decision (slot it):

SET_SLOTS gains ["set-f-trashwarn", "adm-trash-ret"] — the warning travels with the auto-purge checkbox onto the Deleted-files admin page.
syncTrashAuto toggles it: visible exactly while the sweep is off, the state it warns about.
The KNOWN_UNSLOTTED allow-list is emptied (mechanism kept for the next orphan) — removing it first is what produced the red.
sdTrashWarn deleted: dead key, mismatched text, in-mandate per the decision.

Red witnessed twice: the slots guard failed on the orphan once un-allow-listed, and the new web/test/trash-warn.test.js (lifts syncTrashAuto, fake $) failed on the missing toggle. Green: both, plus the full web suite and the extract gate.

Recon turned #579's either/or into a sharper finding: `set-f-trashwarn` is not a setting but the **"deleted files accumulate without limit" notice**, and it was *doubly* orphaned — never in `SET_SLOTS` (so it rendered on no page) and never toggled by `syncTrashAuto` (so even slotted it would never have appeared). A second orphan rode along: `sdTrashWarn`, a ×4-translated description for a "warn people in the file browser" feature that was never built and is referenced nowhere. Per the decision (slot it): - `SET_SLOTS` gains `["set-f-trashwarn", "adm-trash-ret"]` — the warning travels with the auto-purge checkbox onto the Deleted-files admin page. - `syncTrashAuto` toggles it: visible exactly while the sweep is off, the state it warns about. - The `KNOWN_UNSLOTTED` allow-list is emptied (mechanism kept for the next orphan) — removing it first is what produced the red. - `sdTrashWarn` deleted: dead key, mismatched text, in-mandate per the decision. **Red witnessed twice:** the slots guard failed on the orphan once un-allow-listed, and the new `web/test/trash-warn.test.js` (lifts `syncTrashAuto`, fake `$`) failed on the missing toggle. Green: both, plus the full web suite and the extract gate.

Cordy added 1 commit

2026-09-18 02:50:06 +00:00