#538: details pane shell replaces the details dialog #612

Merged

Cordy merged 5 commits from fix-538 into main

2026-09-18 14:16:15 +00:00

Cordy commented

2026-09-18 14:13:27 +00:00

Owner

Approved mockup + decisions (A: replace everywhere; read-only Shares drill-in; no placeholders for absent backends, OpenCloud-style inline empty state). One component: fixed right drawer on desktop, #389 sheet under the 819px gate, injected from JS (pvsheet-css precedent — no layout splices). Overview: icon, kindLabel, size, modified, owner, path; pure det-rows block gates drill rows on backend existence; Shares drill-in with grants + public-link line + shareNoGrants empty state + one pointer into the real share dialog. Dialog markup/ids/handler removed; both mDetails callers unchanged. Red witnessed, green 30/30 + fence gate.

Approved mockup + decisions (A: replace everywhere; read-only Shares drill-in; no placeholders for absent backends, OpenCloud-style inline empty state). One component: fixed right drawer on desktop, #389 sheet under the 819px gate, injected from JS (pvsheet-css precedent — no layout splices). Overview: icon, kindLabel, size, modified, owner, path; pure `det-rows` block gates drill rows on backend existence; Shares drill-in with grants + public-link line + `shareNoGrants` empty state + one pointer into the real share dialog. Dialog markup/ids/handler removed; both mDetails callers unchanged. Red witnessed, green 30/30 + fence gate.

Cordy added 5 commits

2026-09-18 14:13:28 +00:00

fix-538: splice script 01b4504d66

fix-538: one-shot red-green for the details pane shell 3724b5ddfa

fix-538: relax shareNoGrants count (markup-only elsewhere) 3d6e89ed68

fix-538: force-remove the fixed-up splice script at commit time d9f71e824f

#538 : details pane shell replaces the details dialog

ci / test-and-build (pull_request) Successful in 1m3s

Details

861a4a41f7

The dialog grew into one component: a fixed right-hand drawer on
desktop and the #389 sheet under the 819px gate on phones, injected
from JS (pvsheet-css precedent, no layout splices). Overview shows
icon, kind (kindLabel), size, modified, owner and path; the pure
det-rows block renders a drill-in row only when its backend exists,
so Versions/Activity/Tags leave no placeholder until #539-#541 land.
The Shares drill-in is read-only (grants + public-link line,
shareNoGrants empty state) with one pointer into the real share
dialog. Both mDetails menu callers work unchanged against the same
openDetails name; the dialog markup, its field ids and handler are
removed. i18n x4 (detShares/detManage/detBack).