QA batch 3 - legal holds tell the truth (v0.6.250) #699

Merged

Cordy merged 12 commits from fix-qa3 into main

2026-09-23 19:11:20 +00:00

Cordy commented

2026-09-23 19:08:19 +00:00

Owner

Third batch of the v0.7 QA findings: the legal-holds cluster.

Retention checker lists every hold affecting a path (new hold.Store.Matching, styled hold lines in the resolve output) (#685)
Hold placement validates the path against the unscoped backend — mis-spelled holds that protect nothing are rejected with a namespace hint (#685)
Lifting a hold confirms via a canon fact dialog (path, placed-by, when, original reason) and records a lift reason in the audit event (new audit.Event.Note) (#683)

Red-green: web/test/qa3.test.js, internal/storage/hold/matching_test.go, internal/api/qa3_test.go. i18n x4 for the four new keys.

Note for QA cleanup: the two bogus holds on files ("/Fall 1", "/Spaces/Fall 1") predate the validation — lift them via the new dialog.

Closes #685
Closes #683

Third batch of the v0.7 QA findings: the legal-holds cluster. - Retention checker lists every hold affecting a path (new `hold.Store.Matching`, styled hold lines in the resolve output) (#685) - Hold placement validates the path against the unscoped backend — mis-spelled holds that protect nothing are rejected with a namespace hint (#685) - Lifting a hold confirms via a canon fact dialog (path, placed-by, when, original reason) and records a lift reason in the audit event (new `audit.Event.Note`) (#683) Red-green: web/test/qa3.test.js, internal/storage/hold/matching_test.go, internal/api/qa3_test.go. i18n x4 for the four new keys. Note for QA cleanup: the two bogus holds on files ("/Fall 1", "/Spaces/Fall 1") predate the validation — lift them via the new dialog. Closes #685 Closes #683

Cordy added 12 commits

2026-09-23 19:08:20 +00:00

scout: legal holds surfaces (#685 #683 ) d6fa6d28bf

scout: legal holds surfaces, guarded (#685 #683 ) 1afd83fa7f

scout: holds/retention frontend bodies f47bde698d

RED: QA batch 3 pins - legal holds (#685 #683 ) 2cdbb14e8c

RED: hold.Store.Matching lists holds affecting a path (#685 ) 64f60d9cad

RED: hold placement validates the path; audit events can carry a note (#685 #683 ) 4d81c60afe

GREEN splice: legal holds (#685 #683 ) 0cfdd441bb

one-shot: QA batch 3 red-green (#685 #683 ) 97920fd3e4

QA batch 3 - legal holds tell the truth (#685 #683 ) a55c638fd9

The retention checker lists every hold affecting a path (new hold.Store.Matching); placing a hold validates the path against the unscoped backend so a mis-spelled hold can no longer sit active while protecting nothing; lifting a hold confirms through a canon fact dialog and records a reason in the audit event (new audit.Event.Note).

chg-250: changelog entry for v0.6.250 4e6d21db37

one-shot: changelog v0.6.250 47e5346e92

changelog: v0.6.250

ci / test-and-build (pull_request) Successful in 1m12s

Details

73c11417a3