#690: opt-in group space - app groups stop synthesizing /spaces #710

Merged

Cordy merged 20 commits from feat-690 into main

2026-09-24 02:29:17 +00:00

Cordy commented

2026-09-24 02:26:04 +00:00

Owner

Closes #690

App-owned groups are principals, not spaces. auth.WithAppGroups merging group names into User.Groups made every app group silently appear as /spaces/<group>; this PR ends that and replaces it with an explicit opt-in.

scope: new WithGroupExclusion(fn) predicate (wired to GroupStore.Has in main.go) removes app groups from /spaces synthesis in both the listing and path resolution. A provisioned space of the same name still grants through the spacestore.
spacestore: Space.Group link + SetGroup/FindByGroup.
groups API: POST /admin/groups accepts space/spaceName (default "<group> space"), provisions and links the space, materializes members as write members; member add/remove mirrors into the linked space (owner never evicted); DELETE /admin/groups/{id} on a linked group requires ?space=delete|keep (409 without), delete = trash + deactivate + tombstone, keep = unlink; appGroupRow.Space and spaceEntry.Group surface the link.
UI: New-group checkbox with prefilled, hand-edit-tracked space name (approved mockup, both amendments); interim guNewSpaceNote hint removed; delete dialog gains fate radios; spaces inventory shows Owned by X · group Y; 8 new i18n keys ×4.
Tests: scope_exclude_test.go, spacestore/grouplink_test.go, api/groups_space_test.go, web/test/qa690.test.js; the stale interim pin in qa2.test.js retired.

No migration for previously synthesized dogfood spaces by design (manual cleanup, per decision on the issue).

Closes #690 App-owned groups are principals, not spaces. `auth.WithAppGroups` merging group names into `User.Groups` made every app group silently appear as `/spaces/<group>`; this PR ends that and replaces it with an explicit opt-in. - **scope**: new `WithGroupExclusion(fn)` predicate (wired to `GroupStore.Has` in main.go) removes app groups from `/spaces` synthesis in both the listing and path resolution. A provisioned space of the same name still grants through the spacestore. - **spacestore**: `Space.Group` link + `SetGroup`/`FindByGroup`. - **groups API**: `POST /admin/groups` accepts `space`/`spaceName` (default `"<group> space"`), provisions and links the space, materializes members as write members; member add/remove mirrors into the linked space (owner never evicted); `DELETE /admin/groups/{id}` on a linked group requires `?space=delete|keep` (409 without), delete = trash + deactivate + tombstone, keep = unlink; `appGroupRow.Space` and `spaceEntry.Group` surface the link. - **UI**: New-group checkbox with prefilled, hand-edit-tracked space name (approved mockup, both amendments); interim `guNewSpaceNote` hint removed; delete dialog gains fate radios; spaces inventory shows `Owned by X · group Y`; 8 new i18n keys ×4. - **Tests**: `scope_exclude_test.go`, `spacestore/grouplink_test.go`, `api/groups_space_test.go`, `web/test/qa690.test.js`; the stale interim pin in `qa2.test.js` retired. No migration for previously synthesized dogfood spaces by design (manual cleanup, per decision on the issue).

Cordy added 20 commits

2026-09-24 02:26:05 +00:00

scout: f690 go-side map A d0d7d7e1a3

scout: f690 go-side bodies B e2da28600c

scout: f690 go-side bodies C accbfa56d7

scout: f690 go-side bodies D 84b240b8ab

scout: f690 go-side bodies E fcc85a3dd8

scout: f690 test harness F 65b7258c3f

scout(#690 ): exact UI anchors for gadddlg/gdeldlg/renderer/main wiring