Spaces overview round 4: spacesov supersedes /spaces, toolbar parity, controlled image crop, kind-aware batch bar, help popover (#783) #784

Merged
Cordy merged 3 commits from feat-783 into main 2026-09-28 01:07:16 +00:00
Owner

Closes #783. Nikola's second pass + my self-review flags, one release.

Supersede: load() intercepts exactly /spaces (then-able return openSpacesView()), covering crumb, bookmarks, boot restore and the lifecycle fallbacks — the folder view of /spaces retires from the UI.

Toolbar parity: #fileactions shows in spacesov; per-fbview CSS hides upload/New/Members/file-sort/gear, leaving the global view-mode dropdown live. Mode switches re-render the overview (wireViewTog hook). Condensed = spovcond table (no subtitles, tight rows, smaller chips); Tiles = .spovgrid of .spovcards (banner or initial, name, subtitle, members/Directory/Deactivated meta line, kebab; no checkboxes — batch ops live in list). Overview-specific sort select (name A–Z/Z–A, size, most members) persisted as prefs.spovSort, applied by re-appending rows/cards.

Kind-aware batch bar: directory rows lose their checkbox (it.dirSp from /meta.kind) — no more guaranteed-404 lifecycle actions on IdP instances; filtering deselects hidden rows; batch Deactivate gains a fact-row confirm (qa693 census 14→15); tally: "n spaces — a active, d deactivated, x directory-managed · measured".

Controlled image crop: Choose previews via URL.createObjectURL; 16:9 frame with pointer-drag pan and centre-anchored zoom slider; Save draws the visible crop to a 1280×720 canvas → JPEG blob → PUT; Cancel reverts to the idle view and discards. Remove unchanged. Server-side re-encode stays the safety net.

Help popover: "?" beside the overview search with the about-spaces explainer, i18n ×4.

Also: qa769's stale colModified pin now points honestly at the details row. One splice near-miss caught locally before any push: the image-dialog span terminator would have swallowed the rename dialog (spacerendlg sits between it and spcdetaildlg) — fixed, with a survives-the-span post-condition added.

Verified locally on pushed bytes (RED → splice → full 237-test suite green), repeated by the runner one-shot.

Closes #783. Nikola's second pass + my self-review flags, one release. **Supersede:** `load()` intercepts exactly `/spaces` (then-able `return openSpacesView()`), covering crumb, bookmarks, boot restore and the lifecycle fallbacks — the folder view of /spaces retires from the UI. **Toolbar parity:** `#fileactions` shows in `spacesov`; per-fbview CSS hides upload/New/Members/file-sort/gear, leaving the global view-mode dropdown live. Mode switches re-render the overview (`wireViewTog` hook). Condensed = `spovcond` table (no subtitles, tight rows, smaller chips); Tiles = `.spovgrid` of `.spovcard`s (banner or initial, name, subtitle, members/Directory/Deactivated meta line, kebab; no checkboxes — batch ops live in list). Overview-specific sort select (name A–Z/Z–A, size, most members) persisted as `prefs.spovSort`, applied by re-appending rows/cards. **Kind-aware batch bar:** directory rows lose their checkbox (`it.dirSp` from `/meta.kind`) — no more guaranteed-404 lifecycle actions on IdP instances; filtering deselects hidden rows; batch Deactivate gains a fact-row confirm (qa693 census 14→15); tally: "n spaces — a active, d deactivated, x directory-managed · measured". **Controlled image crop:** Choose previews via `URL.createObjectURL`; 16:9 frame with pointer-drag pan and centre-anchored zoom slider; Save draws the visible crop to a 1280×720 canvas → JPEG blob → PUT; Cancel reverts to the idle view and discards. Remove unchanged. Server-side re-encode stays the safety net. **Help popover:** "?" beside the overview search with the about-spaces explainer, i18n ×4. Also: qa769's stale colModified pin now points honestly at the details row. One splice near-miss caught locally before any push: the image-dialog span terminator would have swallowed the rename dialog (spacerendlg sits between it and spcdetaildlg) — fixed, with a survives-the-span post-condition added. Verified locally on pushed bytes (RED → splice → full 237-test suite green), repeated by the runner one-shot.
Cordy merged commit baeb281fd0 into main 2026-09-28 01:07:16 +00:00
Cordy deleted branch feat-783 2026-09-28 01:07:18 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#784
No description provided.