Federated shares out are missing from the administrator's Shares list #1071

Closed
opened 2026-11-02 12:10:58 +00:00 by Cordy · 7 comments
Owner

Problem. Administration › Sharing › Shares (#833) lists links and shares with people and groups, with states, filters, revoke, export and the share review. Shares out over Open Cloud Mesh are not in it.

  • An administrator cannot see that a file is shared with an address on another server, and cannot revoke it there.
  • The export and the review do not count it.
  • Since #1057 (v0.6.385) these shares have the same states as links and grants, so the gap shows more.

Today.

  • internal/api/admin_shares.go builds the rows from the share store only.
  • OCM shares out live in ocm-shares-out.json. Only their owner sees them, under Federated and Shares › Shared with others.
  • sharereport and the share review have no federated rows.

Proposal.

  • Rows: a third kind federated with id o:<providerId>, the item's current path and area, owner, the remote address and server, role, created and status. The status comes from the same state function as the owner's list: active, frozen, paused, paused-trash, paused-handover, item-missing or item-replaced, plus handover. Ended rows are not listed.
  • Filter and search: a Federated chip, and search over the remote address and server.
  • Revoke: ends the share like the owner's End share, sending SHARE_UNSHARED. It writes the existing admin revoke audit with ocm=<providerId>, and the owner gets the share-admin-revoked bell.
  • Export and review: the CSV and PDF exports carry the rows, and the review counts them.
  • Needs a whole-page mockup and string approval first.

Acceptance. Admin-list tests for each state, including a departed owner shown as frozen; filters and search; revoke ends the share, notifies the other server and audits; the export and review include the rows; web tests for the chip, the row and the revoke confirm.

Refs. #1057 (decision: separate issue), research-1057.md Q11, #833.

**Problem.** Administration › Sharing › Shares (#833) lists links and shares with people and groups, with states, filters, revoke, export and the share review. Shares out over Open Cloud Mesh are not in it. - An administrator cannot see that a file is shared with an address on another server, and cannot revoke it there. - The export and the review do not count it. - Since #1057 (v0.6.385) these shares have the same states as links and grants, so the gap shows more. **Today.** - `internal/api/admin_shares.go` builds the rows from the share store only. - OCM shares out live in `ocm-shares-out.json`. Only their owner sees them, under Federated and Shares › Shared with others. - `sharereport` and the share review have no federated rows. **Proposal.** - **Rows:** a third kind `federated` with id `o:<providerId>`, the item's current path and area, owner, the remote address and server, role, created and status. The status comes from the same state function as the owner's list: `active`, `frozen`, `paused`, `paused-trash`, `paused-handover`, `item-missing` or `item-replaced`, plus `handover`. Ended rows are not listed. - **Filter and search:** a **Federated** chip, and search over the remote address and server. - **Revoke:** ends the share like the owner's End share, sending `SHARE_UNSHARED`. It writes the existing admin revoke audit with `ocm=<providerId>`, and the owner gets the `share-admin-revoked` bell. - **Export and review:** the CSV and PDF exports carry the rows, and the review counts them. - Needs a whole-page mockup and string approval first. **Acceptance.** Admin-list tests for each state, including a departed owner shown as `frozen`; filters and search; revoke ends the share, notifies the other server and audits; the export and review include the rows; web tests for the chip, the row and the revoke confirm. **Refs.** #1057 (decision: separate issue), research-1057.md Q11, #833.
Author
Owner

Research done (research-1071.md).

What the code does now

  • The admin list, revoke, export and review count are built only from the share store (admin_shares.go). The OCM ledger is never read there.
  • ocm.OutState never returns frozen or paused, so the admin rows need their own owner-liveness check.
  • An admin revoke would read as "Ended: deleted for good" on the owner's side, so it needs a new "Ended by an administrator" line.
  • Removing a server ends all its shares without a per-share audit record or an owner notice.

Market: Nextcloud Share Review, SharePoint/OneDrive, Google Workspace, Box and Dropbox all list external shares for admins and let them remove them. ownCloud 10, oCIS and Seafile don't.

Standards: ISO 27001 A.5.18 (access review) and GDPR Art. 30/15 (recipients).

Recommendation

  • Add a federated row kind, read fresh from the ledger, with the status order departed, earlier account, disabled, then the owner's states.
  • Revoke goes through EndOut with reason admin-revoked and the background sender, plus the existing admin audit, the owner's bell and an Ended line.
  • Add a fifth Federated button to the Type control.
  • Include the rows in the export and review, and list pending shares.
  • Fold the server-removal gap into this issue.
  • Mockup frames A-J are listed in the file. Decisions follow.
**Research done** (`research-1071.md`). **What the code does now** - The admin list, revoke, export and review count are built only from the share store (`admin_shares.go`). The OCM ledger is never read there. - `ocm.OutState` never returns frozen or paused, so the admin rows need their own owner-liveness check. - An admin revoke would read as "Ended: deleted for good" on the owner's side, so it needs a new "Ended by an administrator" line. - Removing a server ends all its shares without a per-share audit record or an owner notice. **Market:** Nextcloud Share Review, SharePoint/OneDrive, Google Workspace, Box and Dropbox all list external shares for admins and let them remove them. ownCloud 10, oCIS and Seafile don't. **Standards:** ISO 27001 A.5.18 (access review) and GDPR Art. 30/15 (recipients). **Recommendation** - Add a `federated` row kind, read fresh from the ledger, with the status order departed, earlier account, disabled, then the owner's states. - Revoke goes through `EndOut` with reason `admin-revoked` and the background sender, plus the existing admin audit, the owner's bell and an Ended line. - Add a fifth Federated button to the Type control. - Include the rows in the export and review, and list pending shares. - Fold the server-removal gap into this issue. - Mockup frames A-J are listed in the file. Decisions follow.
Author
Owner

Decisions (Nikola, 2026-11-02): all recommendations approved.

  • List rows: a federated row kind, read fresh from the ledger. Pending shares are listed. Server and provider show under the recipient.
  • Admin revoke: EndOut with reason admin-revoked through the background sender, with the existing admin audit record, the owner's bell and a new line "Ended by an administrator".
  • While OCM is off: rows are still listed and can be revoked, with a note that the other server can't be told.
  • Filter: a fifth Federated button in the Type control.
  • Exports: the CSV gains server and accepted columns, and the PDF counts federated shares.
  • Server removal: the gap is folded into this issue (a per-share audit record and an owner notice).
  • Not in this issue: incoming shares come later.

A mockup comes next.

**Decisions (Nikola, 2026-11-02):** all recommendations approved. - **List rows:** a `federated` row kind, read fresh from the ledger. Pending shares are listed. Server and provider show under the recipient. - **Admin revoke:** `EndOut` with reason `admin-revoked` through the background sender, with the existing admin audit record, the owner's bell and a new line "Ended by an administrator". - **While OCM is off:** rows are still listed and can be revoked, with a note that the other server can't be told. - **Filter:** a fifth Federated button in the Type control. - **Exports:** the CSV gains `server` and `accepted` columns, and the PDF counts federated shares. - **Server removal:** the gap is folded into this issue (a per-share audit record and an owner notice). - **Not in this issue:** incoming shares come later. A mockup comes next.
Author
Owner

Mockup approved (Nikola, 2026-11-02): 1071-admin-federated-mockup.html. The 15 frames, all strings and every open point are approved:

  1. If the federated records can't be read, the list still shows links and grants with a warning, and the export or scheduled report is refused with 500 (adds the string shFedUnreadable).
  2. After an admin end, the record is read back once and ended again if it shows as live.
  3. The owner's bell opens Federated › server with focus on the Ended line.
  4. No federated count on the Overview card, unless adding it takes one line.
  5. The owner's own End share using the synchronous path goes on the backlog.
**Mockup approved** (Nikola, 2026-11-02): `1071-admin-federated-mockup.html`. The 15 frames, all strings and every open point are approved: 1. If the federated records can't be read, the list still shows links and grants with a warning, and the export or scheduled report is refused with 500 (adds the string `shFedUnreadable`). 2. After an admin end, the record is read back once and ended again if it shows as live. 3. The owner's bell opens Federated › server with focus on the Ended line. 4. No federated count on the Overview card, unless adding it takes one line. 5. The owner's own End share using the synchronous path goes on the backlog.
Author
Owner

Unsettled spec points U1-U8 researched (research-1071-unsettled.md; code at si1070 934b479a). Each point lists the finding, then the recommendation.

  • U1 shFedUnreadable DE/FR/IT. The drafts follow the language guide. Two problems: the ending doesn't match the existing "Reload the page and try again" wording, and the approved EN says "links and people" although groups are listed too. Changed: align the ending in all four languages and say "links, people and groups". The EN change needs Nikola (N1).
  • U2 Mark as reviewed while the ledger can't be read. ISO 27001 A.5.18 and SailPoint's "completeness" principle both reject a review over a list known to be incomplete. A share-store failure already gives 500 today. Confirmed 500, plus two additions:
    • the error code federated-unreadable, shown as shFedUnreadable;
    • the button disabled while the page note shows (N2).
  • U3 Earlier account and the bell. Revoking an earlier account's links and grants already rings the current account's bell today. The bell only hides items dated before the account's start, and an admin revoke is dated now (notify.go:449, :986). Changed: fix this in this batch with one creatorHolds check in adminRevokeOne, instead of a backlog line. This changes #833 behaviour (N4).
  • U4 I1 "OCM off" told line. It can't be reached because ocmGate blocks it. The same gate also stops removing a server while OCM is off, which reverses containment then eradication (NIST SP 800-61r2 3.3). Confirmed: don't wire it here. Follow-up (N3): let the server list and removal pass the gate.
  • U5 Bell "failed" style. Any item with a reason shows the raw reason with a warning icon. group-review items already show "group-review" untranslated today (live bug, no test). Confirmed: exclude share-admin-revoked, and add web tests for group-review and server-removed items.
  • U6 Bulk cost. EndOut already accepts a match set. Ending ids one by one rewrites the whole file 500 times, and each write is a lost-update window (#742). Changed: batch the federated ids of one bulk call (one read, one end, one read-back). EndFederatedShare stays as the one-id wrapper.
  • U7 #1072 entry point. Confirmed, with two guards:
    • FedEnd.Reason only accepts "", admin-revoked or server-removed. Any other reason would show the owner "Ended: deleted for good".
    • #1072 uses addressee= in the note, not recipient=.
  • U8 Export verb. Confirmed: share-export for the export and share-report for the scheduled report, as in the code and the handbook.

New open points:

  • N1: the EN text of shFedUnreadable.
  • N2: disable Export and Mark as reviewed while the ledger is unreadable, and add the error code.
  • N3: allow server removal while OCM is off, as a follow-up issue.
  • N4: confirm the #833 behaviour change for earlier-account tombstones.
**Unsettled spec points U1-U8 researched** (`research-1071-unsettled.md`; code at si1070 `934b479a`). Each point lists the finding, then the recommendation. - **U1 `shFedUnreadable` DE/FR/IT.** The drafts follow the language guide. Two problems: the ending doesn't match the existing "Reload the page and try again" wording, and the approved EN says "links and people" although groups are listed too. **Changed:** align the ending in all four languages and say "links, people and groups". The EN change needs Nikola (N1). - **U2 Mark as reviewed while the ledger can't be read.** ISO 27001 A.5.18 and SailPoint's "completeness" principle both reject a review over a list known to be incomplete. A share-store failure already gives 500 today. **Confirmed 500**, plus two additions: - the error code `federated-unreadable`, shown as `shFedUnreadable`; - the button disabled while the page note shows (N2). - **U3 Earlier account and the bell.** Revoking an earlier account's links and grants already rings the *current* account's bell today. The bell only hides items dated before the account's start, and an admin revoke is dated now (`notify.go:449`, `:986`). **Changed:** fix this in this batch with one `creatorHolds` check in `adminRevokeOne`, instead of a backlog line. This changes #833 behaviour (N4). - **U4 I1 "OCM off" told line.** It can't be reached because `ocmGate` blocks it. The same gate also stops removing a server while OCM is off, which reverses containment then eradication (NIST SP 800-61r2 3.3). **Confirmed:** don't wire it here. Follow-up (N3): let the server list and removal pass the gate. - **U5 Bell "failed" style.** Any item with a `reason` shows the raw reason with a warning icon. `group-review` items already show "group-review" untranslated today (live bug, no test). **Confirmed:** exclude `share-admin-revoked`, and add web tests for `group-review` and `server-removed` items. - **U6 Bulk cost.** `EndOut` already accepts a match set. Ending ids one by one rewrites the whole file 500 times, and each write is a lost-update window (#742). **Changed:** batch the federated ids of one bulk call (one read, one end, one read-back). `EndFederatedShare` stays as the one-id wrapper. - **U7 #1072 entry point.** **Confirmed**, with two guards: - `FedEnd.Reason` only accepts "", `admin-revoked` or `server-removed`. Any other reason would show the owner "Ended: deleted for good". - #1072 uses `addressee=` in the note, not `recipient=`. - **U8 Export verb.** **Confirmed:** `share-export` for the export and `share-report` for the scheduled report, as in the code and the handbook. **New open points:** - N1: the EN text of `shFedUnreadable`. - N2: disable Export and Mark as reviewed while the ledger is unreadable, and add the error code. - N3: allow server removal while OCM is off, as a follow-up issue. - N4: confirm the #833 behaviour change for earlier-account tombstones.
Author
Owner

Decisions on the spec's unsettled points (2026-11-02)

Nikola's decisions on spec section 15 (research: research-1071-unsettled.md, code at 934b479a). The spec and plan in .superpowers/sdd/2026-11-02-ab1071/ now include them. Section 15 is now "Decisions on the unsettled points (2026-11-02)".

  • U1 + N1, shFedUnreadable (changed): the EN is now "Federated shares could not be read. The list shows links, people and groups only. Reload the page to try again."
    • DE: "Föderierte Freigaben konnten nicht gelesen werden. Die Liste zeigt nur Links, Personen und Gruppen. Laden Sie die Seite neu und versuchen Sie es erneut."
    • FR: "Les partages fédérés n’ont pas pu être lus. La liste n’affiche que les liens, les personnes et les groupes. Rechargez la page et réessayez."
    • IT: "Non è stato possibile leggere le condivisioni federate. L’elenco mostra solo link, persone e gruppi. Ricaricare la pagina e riprovare."
    • The ending follows the existing errBadRequest wording.
  • U2 + N2, unreadable ledger (confirmed, extended): Mark as reviewed answers 500 and records nothing. Every ledger failure carries the code federated-unreadable. For review and export this is a 500. The scheduled report records it as Report.Code. The web maps the code to shFedUnreadable. Export and Mark as reviewed are disabled while the page note shows. No new string.
  • U3 / N4, earlier-account bells (not fixed in this batch): the no-bell rule for an earlier account's federated shares stays as written. Links and grants are a separate case. Today an admin revoke of an earlier account's link or grant is dated now, so the current holder of the name sees the bell item (notify.go:449, :986). This goes on the backlog. The fix is a creatorHolds check in adminRevokeOne and in group review.
  • U4 (confirmed): frame I1's "OCM off" told line is not wired.
  • N3 (follow-up): a new issue to allow listing and removing servers while OCM is off (ocmGate; NIST SP 800-61 says contain before you eradicate). Also a backlog line: the Servers tab shows raw English 404 text while OCM is off.
  • U5 (confirmed): share-admin-revoked is excluded from the bell's failed style. New web tests cover a group-review item (today's raw-text bug) and a server-removed item.
  • U6, bulk stop (changed): the federated ids of one bulk call are now ended together: one ledger read, one EndOut over the set, one read-back. EndFederatedShare remains the single-id wrapper. There is no backlog line.
  • U7 (confirmed, with guards): FedEnd.Reason accepts only "", admin-revoked and server-removed; any other value is an error. #1072 uses addressee= in its share-admin-revoke note, not recipient=.
  • U8 (confirmed): the export stays share-export. share-report is the scheduled report.
  • From the #1072 decisions (moved here, ships in v0.6.390):
    • #1072's audit-notes task becomes T7 in W1 here, with its interfaces and tests. It covers NoteFields, two new verbs, and OCM share notes that carry the share id and the other address.
    • ocm-share-send and ocm-share-end move from the access tier to the admin tier, so they are always recorded.
    • The access-logging toggle text (auditEnableDesc, EN/DE/FR/IT drafts in spec section 9) and the handbook sentence in admin-policy.md are updated so they stay true.

Follow-up texts, including notes for #1072: .superpowers/sdd/2026-11-02-ab1071/followup-issues.md.

## Decisions on the spec's unsettled points (2026-11-02) Nikola's decisions on spec section 15 (research: `research-1071-unsettled.md`, code at `934b479a`). The spec and plan in `.superpowers/sdd/2026-11-02-ab1071/` now include them. Section 15 is now "Decisions on the unsettled points (2026-11-02)". - **U1 + N1, `shFedUnreadable` (changed):** the EN is now "Federated shares could not be read. The list shows links, people and groups only. Reload the page to try again." - DE: "Föderierte Freigaben konnten nicht gelesen werden. Die Liste zeigt nur Links, Personen und Gruppen. Laden Sie die Seite neu und versuchen Sie es erneut." - FR: "Les partages fédérés n’ont pas pu être lus. La liste n’affiche que les liens, les personnes et les groupes. Rechargez la page et réessayez." - IT: "Non è stato possibile leggere le condivisioni federate. L’elenco mostra solo link, persone e gruppi. Ricaricare la pagina e riprovare." - The ending follows the existing `errBadRequest` wording. - **U2 + N2, unreadable ledger (confirmed, extended):** Mark as reviewed answers 500 and records nothing. Every ledger failure carries the code `federated-unreadable`. For review and export this is a 500. The scheduled report records it as `Report.Code`. The web maps the code to `shFedUnreadable`. Export and Mark as reviewed are disabled while the page note shows. No new string. - **U3 / N4, earlier-account bells (not fixed in this batch):** the no-bell rule for an earlier account's federated shares stays as written. Links and grants are a separate case. Today an admin revoke of an earlier account's link or grant is dated now, so the current holder of the name sees the bell item (`notify.go:449`, `:986`). This goes on the backlog. The fix is a `creatorHolds` check in `adminRevokeOne` and in group review. - **U4 (confirmed):** frame I1's "OCM off" told line is not wired. - **N3 (follow-up):** a new issue to allow listing and removing servers while OCM is off (`ocmGate`; NIST SP 800-61 says contain before you eradicate). Also a backlog line: the Servers tab shows raw English 404 text while OCM is off. - **U5 (confirmed):** `share-admin-revoked` is excluded from the bell's `failed` style. New web tests cover a `group-review` item (today's raw-text bug) and a `server-removed` item. - **U6, bulk stop (changed):** the federated ids of one bulk call are now ended together: one ledger read, one `EndOut` over the set, one read-back. `EndFederatedShare` remains the single-id wrapper. There is no backlog line. - **U7 (confirmed, with guards):** `FedEnd.Reason` accepts only `""`, `admin-revoked` and `server-removed`; any other value is an error. #1072 uses `addressee=` in its `share-admin-revoke` note, not `recipient=`. - **U8 (confirmed):** the export stays `share-export`. `share-report` is the scheduled report. - **From the #1072 decisions (moved here, ships in v0.6.390):** - #1072's audit-notes task becomes T7 in W1 here, with its interfaces and tests. It covers `NoteFields`, two new verbs, and OCM share notes that carry the share id and the other address. - `ocm-share-send` and `ocm-share-end` move from the access tier to the admin tier, so they are always recorded. - The access-logging toggle text (`auditEnableDesc`, EN/DE/FR/IT drafts in spec section 9) and the handbook sentence in `admin-policy.md` are updated so they stay true. Follow-up texts, including notes for #1072: `.superpowers/sdd/2026-11-02-ab1071/followup-issues.md`.
Cordy closed this issue 2026-11-03 02:15:32 +00:00
Author
Owner

Shipped in v0.6.390 (PR #1080, tag v0.6.390). Both dogfoods run it: pods ready, no restarts, no new WARN/ERROR lines.

What shipped:

  • Federated rows: federated shares out appear in Administration › Sharing › Shares, with the Federated filter, server search, CSV server,accepted, the PDF count and the review count.
  • Unreadable ledger: the list answers federated-unreadable and locks Export and Mark as reviewed.
  • Administrator stop: single and bulk, with an owner bell and the line "Ended by an administrator".
  • Server removal: ends each share out with an audit record, a bell, an Ended line and a background notice.
  • Background sender: drains large batches instead of dropping ends.
  • Audit: ocm-share-send and ocm-share-end are always recorded; audit-tiers is written at start.
  • 409 share-not-live: for ending a share that already ended.

Follow-up decided in the research round: the earlier-account bell leak for links and grants is #1077. Two small items went to the backlog: the server list being unusable while OCM is off, and the raw 404 text there. Live checks are on #1005.

Shipped in **v0.6.390** (PR #1080, tag v0.6.390). Both dogfoods run it: pods ready, no restarts, no new WARN/ERROR lines. What shipped: - **Federated rows:** federated shares out appear in Administration › Sharing › Shares, with the Federated filter, server search, CSV `server,accepted`, the PDF count and the review count. - **Unreadable ledger:** the list answers `federated-unreadable` and locks Export and Mark as reviewed. - **Administrator stop:** single and bulk, with an owner bell and the line "Ended by an administrator". - **Server removal:** ends each share out with an audit record, a bell, an Ended line and a background notice. - **Background sender:** drains large batches instead of dropping ends. - **Audit:** `ocm-share-send` and `ocm-share-end` are always recorded; `audit-tiers` is written at start. - **409 `share-not-live`:** for ending a share that already ended. Follow-up decided in the research round: the earlier-account bell leak for links and grants is #1077. Two small items went to the backlog: the server list being unusable while OCM is off, and the raw 404 text there. Live checks are on #1005.
Author
Owner

Strings approved (Nikola, 2026-11-03): the new and changed keys of v0.6.390 in DE/FR/IT as shipped, listed in the batch's final review. They include shFedUnreadable and auditEnableDesc, and the Italian shFedOffNote in its impersonal form.

**Strings approved (Nikola, 2026-11-03):** the new and changed keys of v0.6.390 in DE/FR/IT as shipped, listed in the batch's final review. They include `shFedUnreadable` and `auditEnableDesc`, and the Italian `shFedOffNote` in its impersonal form.
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#1071
No description provided.