Spaces batch bar adopts the established selection bar (#787) #797

Merged
Cordy merged 3 commits from feat-787 into main 2026-09-28 03:06:22 +00:00
Owner

Closes #787.

Element: a spaces-owned #spovselbar (class selbar) beside the files #selbar — identical structure: .selact icon+label buttons (Deactivate / Reactivate / Delete, icons = MI.pause / MI.play / MI.del paths), .selN count, .selact.selx Clear selection ✕. The files #selbar element is untouched.

Slot swap: own body attribute data-spsel (the files data-sel keeps its single writer, pinned by #788) — shows the bar and hides #fileactions in the same 48px slot; body:not([data-spsel="on"]) #spovselbar guards it out of files views even when a files selection sets the shared .selbar rule. Reset at every overview render and when setView leaves the overview (the symmetric case #788 anticipated — real now that the bar lives outside #listpane).

Actions appear per selection (hidden, not disabled): Deactivate if any active (fact-row confirm, as shipped); Reactivate if any deactivated (no confirm — reversible, like the single-space menu); Delete only when every pick is deactivated (confirm). Edit quota joins with #767; duplicate/download space stay out of scope (commented). askDanger census unchanged at 15.

Retired: the in-panel .spovbar/.spovseln code + CSS (incl. #789's li.spovbar padding rule). qa770/qa778 pins on the old bar updated deliberately.

Verification: RED → splice → 282/282. Previewed on the live overview before pushing (element + CSS injected, swap toggled): matches the Recents bar, and the panel's top edge is identical before/after the swap (176.49px — no shift).

Known limit, pre-existing pattern: on phone widths (#389) the files bar's actions move into a bottom sheet; the spaces bar stays in its slot. Worth a follow-up only if the phone pass wants parity.

Closes #787. **Element:** a spaces-owned `#spovselbar` (class `selbar`) beside the files `#selbar` — identical structure: `.selact` icon+label buttons (Deactivate / Reactivate / Delete, icons = MI.pause / MI.play / MI.del paths), `.selN` count, `.selact.selx` Clear selection ✕. The files `#selbar` element is untouched. **Slot swap:** own body attribute `data-spsel` (the files `data-sel` keeps its single writer, pinned by #788) — shows the bar and hides `#fileactions` in the same 48px slot; `body:not([data-spsel="on"]) #spovselbar` guards it out of files views even when a files selection sets the shared `.selbar` rule. Reset at every overview render and when `setView` leaves the overview (the symmetric case #788 anticipated — real now that the bar lives outside `#listpane`). **Actions appear per selection (hidden, not disabled):** Deactivate if any active (fact-row confirm, as shipped); Reactivate if any deactivated (no confirm — reversible, like the single-space menu); Delete only when every pick is deactivated (confirm). Edit quota joins with #767; duplicate/download space stay out of scope (commented). askDanger census unchanged at 15. **Retired:** the in-panel `.spovbar`/`.spovseln` code + CSS (incl. #789's `li.spovbar` padding rule). qa770/qa778 pins on the old bar updated deliberately. **Verification:** RED → splice → 282/282. Previewed on the live overview before pushing (element + CSS injected, swap toggled): matches the Recents bar, and the panel's top edge is identical before/after the swap (176.49px — no shift). Known limit, pre-existing pattern: on phone widths (#389) the files bar's actions move into a bottom sheet; the spaces bar stays in its slot. Worth a follow-up only if the phone pass wants parity.
test: #787 RED - established selection bar
All checks were successful
fix-787 / fix (push) Successful in 13s
1c05506968
Closes #787
docs: changelog for v0.6.298 (#787)
All checks were successful
ci / test-and-build (pull_request) Successful in 1m36s
b957131937
Cordy merged commit 72ce5a900f into main 2026-09-28 03:06:22 +00:00
Cordy deleted branch feat-787 2026-09-28 03:06:25 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#797
No description provided.