Local account delete: make app-password removal retryable #849

Closed
opened 2026-10-06 16:55:51 +00:00 by Cordy · 0 comments
Owner

Follow-up from #838/#839 (final review, minor).

localUserDelete deletes the account first, then that user's app passwords. If the second step fails (a write failure on the app-password store), the admin gets a 500, the audit row records app-passwords=error, and the app passwords keep working. Retrying Delete then returns 404, so nothing in the UI can finish the cleanup.

Fix direction: remove the app passwords before the account, or make delete idempotent so a retry on a missing account still removes the leftover app passwords. Add a test with a failing app-password store.

Follow-up from #838/#839 (final review, minor). `localUserDelete` deletes the account first, then that user's app passwords. If the second step fails (a write failure on the app-password store), the admin gets a 500, the audit row records `app-passwords=error`, and the app passwords keep working. Retrying Delete then returns 404, so nothing in the UI can finish the cleanup. **Fix direction:** remove the app passwords before the account, or make delete idempotent so a retry on a missing account still removes the leftover app passwords. Add a test with a failing app-password store.
Cordy closed this issue 2026-10-07 18:33:05 +00:00
Sign in to join this conversation.
No labels
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#849
No description provided.