Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "revocation-838-839"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #838, closes #839.
Spec:
docs/superpowers/specs/2026-10-03-revocation-design.md. Plan:docs/superpowers/plans/2026-10-06-revocation.md. Each of the 8 tasks was implemented by a subagent and passed a task review; this was followed by a whole-branch review, one fix wave and one residual fix.What changes
auth.directoryRecheck(default 5m, allowed range 30s to 1h). Accounts that are deleted or disabled are signed out: ADuserAccountControl, Keycloakenabled, checked by user id. While the directory is unreachable, the last known state is kept and retried every 30s, with a 3s cap and dedupe per user.auth.ldapCacheTTL. During an outage a cached credential is still served. Binds are bounded to 10s.POST /auth/backchannel-logout. It validates iss, aud, iat, events and nonce absence, and keeps a jti replay cache. JWKS refreshes have a cooldown so unauthenticated callers can't use Cairn to hammer the IdP. Body cap 64 KiB. Outside OIDC mode it answers 501.auth-sessions-revoked,auth-directory-change. "Signed in now" counts only valid sessions.Verification
go vet,go test ./...(53 packages),-raceon auth/api/spaces/config, and the web tests all pass.Not in this PR
Final review finding 2: a directory username that differs from the lookup key read as a deletion and signed everyone out. - LDAP Recheck retries through the login filter when the UsernameAttr search finds nothing; only zero on both is exists=false, more than one is still an error. - OIDC: ResolverConfig.Recheck gains the session's sub; with one present the Keycloak user is fetched by id (GET /users/{id}, 404 = gone) via the new spaces.Manager.UserStatusByID. Sessions without a sub and app-password users keep the username lookup.Final review finding 9: Users & access printed Go durations ("every 5m", "alle 5m"). The pure render helper now formats them per locale with singular and plural units: "every 5 minutes", "alle 5 Minuten", "toutes les 5 minutes", "ogni 5 minuti", "1 minute 30 seconds".