fix(admin): storage draws once, custody token labelled, trash and largest home get real numbers #363

Merged

Cordy merged 7 commits from fix/storage-overview into main

2026-08-28 15:23:41 +00:00

Cordy commented

2026-08-28 15:23:28 +00:00

Owner

Sweep findings A1+A2+A3.

Storage → Usage rendered the old #301 card and the new page together: setAdminTab still called the retired loadStorageCard, which re-showed the card the new renderer had just hidden. Call and function removed.
The raw config token keycloak-profile appeared as the "Encryption" value on Overview and Storage. Both now map through the same custody labels the Encryption page uses (pure:enc-mode, covered by web/test/enc-mode.test.js), and the Overview row is named "At-rest encryption".
The Trash figure was blank: fmtSize(0) returns "", and a trashed directory's meta records size 0. Added the 0 B fallback and sumTree (bounded BFS, mutation-tested) so the admin trash listing sums directory entries.
The mockup's Largest home card existed only as a comment explaining its absence. Per-home sizes now ride the same 24h PrefixSizer cache as spaces (Admin.HomeSizes); adminInfo reports largestHome.
CI's web checks ran only one of the four web tests; now runs web/test/*.test.js.

Sweep findings A1+A2+A3. - Storage → Usage rendered the old #301 card and the new page together: `setAdminTab` still called the retired `loadStorageCard`, which re-showed the card the new renderer had just hidden. Call and function removed. - The raw config token `keycloak-profile` appeared as the "Encryption" value on Overview and Storage. Both now map through the same custody labels the Encryption page uses (`pure:enc-mode`, covered by web/test/enc-mode.test.js), and the Overview row is named "At-rest encryption". - The Trash figure was blank: `fmtSize(0)` returns `""`, and a trashed directory's meta records size 0. Added the 0 B fallback and `sumTree` (bounded BFS, mutation-tested) so the admin trash listing sums directory entries. - The mockup's Largest home card existed only as a comment explaining its absence. Per-home sizes now ride the same 24h PrefixSizer cache as spaces (`Admin.HomeSizes`); adminInfo reports `largestHome`. - CI's web checks ran only one of the four web tests; now runs `web/test/*.test.js`.

Cordy added 7 commits

2026-08-28 15:23:28 +00:00

feat(admin): largestHome helper 2c91de76ef

test(admin): largestHome 71a31a475d

feat(trash): sumTree for directory entry sizes 98f6bd060a

test(trash): sumTree df3c52f7d5

test(web): enc-mode custody token mapping 9485b17ff1

one-shot: storage/overview cleanup splices 64d86ccfb3

fix(admin): storage page draws once, custody token gets its label, trash and largest home get real numbers

ci / test-and-build (pull_request) Successful in 39s

Details

46251512fa

Storage > Usage rendered twice: setAdminTab still called the retired
loadStorageCard, which re-showed the old #301 card after the new page had
hidden it. The call and the function are gone.

The raw config token 'keycloak-profile' appeared verbatim as the value of
'Encryption' on Overview and Storage. Both now map it through the same
custody labels the Encryption page uses (pure:enc-mode block, tested),
and Overview calls the row what it is: At-rest encryption.

The Trash figure was blank because fmtSize(0) returns "" and because a
trashed directory's meta records size 0. fmtSize gets a 0 B fallback and
the admin listing now sums a directory entry's trashed tree (sumTree,
bounded, tested with mutation checks).

The mockup's Largest home card existed only as a comment explaining its
absence. Per-home sizes now ride the same day-old PrefixSizer cache the
spaces page uses (HomeSizes), and adminInfo reports the largest.

CI's web checks ran exactly one of the four web tests; now runs them all.