Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix-923"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #923 and #927, and closes the rename path of #931.
Spec:
docs/superpowers/specs/2026-10-16-fix-923-design.md. Plan:docs/superpowers/plans/2026-10-16-fix-923.md. Every task went through TDD and a task review. Then a whole-branch review, a docs accuracy review, and fix rounds for each.Security
/api/v1/spaces/{name}routes: a session admin, or a member under the membership rule. Everyone else, including Basic admins, gets a byte-identical 404, the same as for a missing space. NFC and NFD forms of a name get the same answer./metaanswers the asked name to everyone else).Tests
Filed along the way
#928, #929, #930, #931 (convergence sweep), #932, #933, #934, #935, #936.
Upgrade notes
See CHANGELOG v0.6.346.
One gate (SpacesAPI.gated) wraps all 19 {name} routes and runs before any syntax check, body parse or lookup: a session admin passes, a member by name or former name (scope.Membership.SpaceNamed) passes, in power mode the recorded owner passes (IdP errors fail closed); everyone else gets spaceNotFound (404, X-Cairn-Code not-found) and one 'spaces: refused' log line. Every existing 'no such space' 404 in the spaces handlers uses the same helper (R2). SpacesAPI.Membership nil fails closed (R11); main.go sets it once after both SpacesAPI branches. Tests: route table, gate matrix (golden re-recorded: refused cells and R2 404 bodies only), nil membership, power-mode owner, refusal log, no membership copies, main wiring and production membership. Fixtures take testMembership (production chain, R12); three leak tests rewritten; non-member 403s become 404 with a member 403 row kept.