batch-v07c: directory password change ends sessions (#848), admin revokes app passwords (#851), Users & access polish (#859) #866

Merged
Cordy merged 20 commits from batch-v07c into main 2026-10-09 06:56:50 +00:00
Owner

Closes #848
Closes #851
Closes #859

Spec: docs/superpowers/specs/2026-10-08-batch-v07c-design.md. Plan: docs/superpowers/plans/2026-10-08-batch-v07c.md.

  • #848: the periodic directory re-check reads the password-change marker (AD pwdLastSet, OpenLDAP pwdChangedTime, the Keycloak password credential createdDate). It ends browser sessions issued before the change.
    • The cut is placed at the change time minus 2 min and capped at now.
    • Markers are monotonic, so a lagging DC's older value is ignored.
    • AD 0 cuts on the transition into 0.
    • Cuts are scoped to the session source.
    • Outages, and a failure of the Keycloak credentials call, never sign anyone out.
    • App passwords stay.
    • Audited as auth-directory-change reason=password-changed.
  • #851: admin endpoints let an admin count, list and revoke a user's app passwords. Only live records are counted.
    • The reset dialog has a "Also revoke …" checkbox (unticked), and the row menu has "Revoke app passwords (n)".
    • The confirmation dialog follows the approved preview.
    • The user gets a persisted bell notice that can't be muted. Notices are cleared when a local account is deleted.
    • The audit verb is app-passwords-revoked-by-admin.
  • #859: name-rule errors have stable codes and are translated in Add account. The audit page wording is updated and the toggle text is merged. A CHECK NAME badge marks local and config rows.
  • Docs (deployment, users-access, admin-policy, account) and CHANGELOG v0.6.324.

Process: 7 tasks, each reviewed (spec and quality) with fix loops. A final whole-branch review (4 Important findings, all fixed) was followed by a scoped re-review: all addressed. Residual minors are tracked in a follow-up issue.

Closes #848 Closes #851 Closes #859 Spec: `docs/superpowers/specs/2026-10-08-batch-v07c-design.md`. Plan: `docs/superpowers/plans/2026-10-08-batch-v07c.md`. - **#848:** the periodic directory re-check reads the password-change marker (AD `pwdLastSet`, OpenLDAP `pwdChangedTime`, the Keycloak password credential `createdDate`). It ends browser sessions issued before the change. - The cut is placed at the change time minus 2 min and capped at now. - Markers are monotonic, so a lagging DC's older value is ignored. - AD `0` cuts on the transition into `0`. - Cuts are scoped to the session source. - Outages, and a failure of the Keycloak credentials call, never sign anyone out. - App passwords stay. - Audited as `auth-directory-change reason=password-changed`. - **#851:** admin endpoints let an admin count, list and revoke a user's app passwords. Only live records are counted. - The reset dialog has a "Also revoke …" checkbox (unticked), and the row menu has "Revoke app passwords (n)". - The confirmation dialog follows the approved preview. - The user gets a persisted bell notice that can't be muted. Notices are cleared when a local account is deleted. - The audit verb is `app-passwords-revoked-by-admin`. - **#859:** name-rule errors have stable codes and are translated in Add account. The audit page wording is updated and the toggle text is merged. A CHECK NAME badge marks local and config rows. - Docs (deployment, users-access, admin-policy, account) and CHANGELOG v0.6.324. Process: 7 tasks, each reviewed (spec and quality) with fix loops. A final whole-branch review (4 Important findings, all fixed) was followed by a scoped re-review: all addressed. Residual minors are tracked in a follow-up issue.
- a parsed marker not newer than the last accepted one (lagging DC) is
  ignored; a newer one cuts at min(changed-2m, now) without the
  previous-observation floor, so a fresh sign-in is never signed out
- AD pwdLastSet 0 cuts only on the transition into 0
- the cut revokes only sessions of the re-checked source
- GeneralizedTime with fractional seconds and offsets parses
- a Keycloak credentials failure is no signal, WARN at most every 10m
- AppPasswordStore.RevokeUser deletes expired records too but reports
  the live count; audit, notice and response use it, live 0 = no audit
  or notice
- notify.Store.ClearNotices; deleting a local account clears its notices
Cordy merged commit e669875755 into main 2026-10-09 06:56:50 +00:00
Cordy deleted branch batch-v07c 2026-10-09 06:56:53 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Cordy/Cairn#866
No description provided.